Optionally print OM created lines #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurSens
changed the title
bwplotka
reviewed
Dec 22, 2023
ArthurSens
force-pushed
the
om-created-lines
branch
from
c26d312
to
b7d00b2
Compare
ArthurSens
changed the title
ArthurSens
force-pushed
the
om-created-lines
branch
3 times, most recently
from
e930252
to
240345e
Compare
bwplotka
approved these changes
Feb 5, 2024
ArthurSens
force-pushed
the
om-created-lines
branch
2 times, most recently
from
33ed3e6
to
e9c6f77
Compare
bwplotka
approved these changes
Mar 25, 2024
ArthurSens
force-pushed
the
om-created-lines
branch
from
e9c6f77
to
81909c5
Compare
|
We need prometheus/common v0.49.0 for this feature, but this version of prometheus/common requires go 1.21. Therefore, the PR is blocked until we drop support for go 1.20 |
ArthurSens
force-pushed
the
om-created-lines
branch
from
81909c5
to
65df2d7
Compare
|
After quite some work to unblock this, this is finally ready :) Do you want to review again or should I just merge? |
Closed
|
Now that prometheus/prometheus#14356 was merged, should we revive this? :) |
ArthurSens
force-pushed
the
om-created-lines
branch
2 times, most recently
from
eb0f4ef
to
b51b530
Compare
|
Since we have approvals from the past, I'll take the liberty to merge this PR next week :) |
bwplotka
requested changes
Sep 18, 2024
So far all our examples just add one or two metrics, not sure if that's needed 🤷 |
ArthurSens
force-pushed
the
om-created-lines
branch
2 times, most recently
from
3edabb8
to
1523562
Compare
|
@bwplotka should be ready for review again! |
krajorama
reviewed
Oct 8, 2024
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
ArthurSens
force-pushed
the
om-created-lines
branch
from
1523562
to
00fb24c
Compare
|
@bwplotka do you want to take one final look before I merge :) |
bwplotka
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an extra option to print _created lines when OpenMetrics is the chosen exposition format. It's implemented following the conditional option added in prometheus/common#504.