Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including node_guid in InfiniBandDevice #665

Open
di3go-sona opened this issue Sep 12, 2024 · 1 comment
Open

Including node_guid in InfiniBandDevice #665

di3go-sona opened this issue Sep 12, 2024 · 1 comment

Comments

@di3go-sona
Copy link

Hi, at my org we are using the infiniband collector in node_exporter .

For our case it's extremely useful to also export an unique identifier like node_guid that can be read from /sys/class/infiniband/<device>/node_guid

The exporter code heavily relies on the InfiniBandClass contained here, and that identifier is not collected

// InfiniBandDevice contains info from files in /sys/class/infiniband for a
// single InfiniBand device.
type InfiniBandDevice struct {
Name string
BoardID string // /sys/class/infiniband/<Name>/board_id
FirmwareVersion string // /sys/class/infiniband/<Name>/fw_ver
HCAType string // /sys/class/infiniband/<Name>/hca_type
Ports map[uint]InfiniBandPort
}

Is there any design reason for this choic,e or can I just contribute a PR for that ?

@discordianfish
Copy link
Member

Sounds reasonable, so a PR would be welcome.

di3go-sona added a commit to di3go-sona/procfs that referenced this issue Oct 2, 2024
di3go-sona added a commit to di3go-sona/procfs that referenced this issue Oct 2, 2024
di3go-sona added a commit to di3go-sona/procfs that referenced this issue Oct 2, 2024
Signed-off-by: Diego Sonaglia <diego.sonaglia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants