Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move example files to examples folder #7

Merged
merged 3 commits into from
Sep 1, 2022

Conversation

HelgeGehring
Copy link

I think it would be good to make an examples folder for the examples to let the user have a rather clean notebook to directly start simulating

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Apache 2.0 License check successful!

@proppy
Copy link
Owner

proppy commented Aug 9, 2022

Can you also update https://github.com/proppy/rad-lab/blob/tuning/modules/silicon_design/scripts/build/cloudbuild.yaml#L39 so that it only copy stuff in examples?

@HelgeGehring
Copy link
Author

Why are the examples at all in the bucket? Shouldn't they just be in the notebook? Also, would there be a way to also update them in the notebooks when the image is updated?

@proppy
Copy link
Owner

proppy commented Aug 12, 2022

Why are the examples at all in the bucket?

@HelgeGehring it seems that /home/jupyter get mounted from the VM in the jupyter container at startup so anything that we would but in /home/jupyter during the image building process would get effectively shadowed by the mount.

Copying them from GCS during the startup script seemed like a good workaround, but maybe provisining a dataDisk would be a proper way to achieve this (assuming it would get mounted instead at /home/jupyter)

@HelgeGehring
Copy link
Author

Okay, sounds good, then copying the examples (and deleting the folder before) seems like a nice solution!

@HelgeGehring
Copy link
Author

I've additionally added folders for electronics and photonics (and added there an mmi-tuning-example)

@proppy proppy merged commit 45121ac into proppy:tuning Sep 1, 2022
@proppy
Copy link
Owner

proppy commented Sep 1, 2022

FYI, renamed the eletric dir to digital: 8c40f9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants