Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech debt #1391

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Tech debt #1391

wants to merge 15 commits into from

Conversation

HughParry
Copy link
Contributor

No description provided.

@HughParry HughParry changed the base branch from main to staging September 23, 2024 09:44
forgetso
forgetso requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@forgetso forgetso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small comments but overall LGTM

packages/account/src/config/getMnemonic.ts Outdated Show resolved Hide resolved
packages/account/tsconfig.json Outdated Show resolved Hide resolved
goastler
goastler requested changes Sep 23, 2024
View reviewed changes
packages/account/src/config/getPair.ts Show resolved Hide resolved
packages/account/src/extension/ExtensionWeb2.ts Show resolved Hide resolved
packages/account/tsconfig.json Outdated Show resolved Hide resolved
packages/common/src/tests/array.test.ts Show resolved Hide resolved
packages/common/src/tests/logger.test.ts Outdated Show resolved Hide resolved
packages/common/src/tests/logger.test.ts Show resolved Hide resolved
@HughParry HughParry marked this pull request as draft October 14, 2024 18:33
Base automatically changed from staging to main October 18, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forgetso forgetso forgetso requested changes

@goastler goastler goastler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HughParry @goastler @forgetso