-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
* chore: upgrade checkout to v3 * chore: upgrade setup-go to v3
before release, web3 bot issues: 31 |
* feat: enable support for opting in to technical preview updates (#365) * feat: use source_ref property to determine what ref to copy workflows from * docs: document how to opt-in to technical preview versions * feat: allow manual dispatches of the dispatch workflow * feat: add go-libp2p to preview * chore: remove go-libp2p from preview Co-authored-by: Piotr Galar <piotr.galar@gmail.com>
After release, web3 bot issues: 94 A few new js errors I checked a few go repos, they were all failing because of (deprecated) ioutils errors. |
Do we know how many these are? Is there a list of those repos? |
This would be a list of all PRs that were created since yesterday and were not merged automatically - https://github.com/search?q=is%3Aopen+author%3Aweb3-bot+created%3A%3E%3D2022-08-23 |
That's 61 Go repositories out of ~120 that Unified CI is configured for. Do we have a plan to get all these PRs merged? |
Ideally, we'll see the PRs getting merged by maintainers (we included a link to an example of how to fix the ioutil deprecation in the communication we shared around the release to ease this process). Since we still don't have a great ownership story everywhere though, we'll definitely be helping with that ourselves too, just as we did in the past. Since the volume is quite hefty and there might be other errors lurking around in some repos, I'm afraid we don't have a specific timeline for this. |
I thought this wouldn't be necessary, but I clearly underestimate the magnitude of the problem: we could automate this. The deprecation of
The only tricky one, as far as I can see, is This could be done as part of the copy workflow, since it's a noop for repos that don't use ioutil. @galargh, wdyt? |
Sure, if it's that straightforward I think it'd make sense to automate it and either add it to the copy workflow or just run the script locally. I'll check how many of those 60+ repos actually use |
Cool, thank you @galargh! I'd be happy to review, feel free to tag me. |
I just got the stats:
I think this proves that it'd be worth to automate the |
We forgot to clear |
Resolves #362
Plan
How to opt-in to Go 1.19 before we perform the official Unified CI release?
I described it in the technical preview section of the README. The logic that enables it is already checked in to
master
.Testing
next
toprotocol/.github-test-target
- sync: update CI config files .github-test-target#37