Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark nested builder as clean after clear is called #10984

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Mark nested builder as clean after clear is called #10984

merged 4 commits into from
Nov 14, 2022

Commits on Nov 14, 2022

  1. Mark nested builder as clean after clear is called 

    Omitting this step was leading to stale cached versions of nested messages.
See #10624
    @googleberg
    googleberg authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    8e6afef View commit details
    Browse the repository at this point in the history

  2. Add timing belt to nested_builders_test protos 

    This will be used in verfication of #10624
    @googleberg
    googleberg authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    f616e70 View commit details
    Browse the repository at this point in the history

  3. Add test to verify nested builder fix. 

    Verify fix for #10624
    @googleberg
    googleberg authored Nov 14, 2022
    Configuration menu
    Copy the full SHA
    8d38060 View commit details
    Browse the repository at this point in the history

  4. Fix misplacement of TimingBelt in the nested_builders_test.proto 

    hierarchy.
    @googleberg
    googleberg committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    736e9b8 View commit details
    Browse the repository at this point in the history