Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: toolchainize language runtimes #14590

Closed
wants to merge 13 commits into from
Closed

refactor: toolchainize language runtimes #14590

wants to merge 13 commits into from

Conversation

thesayyn
Copy link
Contributor

@thesayyn thesayyn commented Nov 1, 2023 •
edited
Loading

Working towards bazelbuild/rules_proto#179

thesayyn
thesayyn commented Nov 14, 2023
View reviewed changes
.bazelversion Outdated Show resolved Hide resolved
@thesayyn thesayyn changed the title wip: begin toolchainization refactor: enable incompatible_enable_proto_toolchain_resolution Nov 14, 2023
comius
comius reviewed Nov 14, 2023
View reviewed changes
BUILD.bazel Show resolved Hide resolved
BUILD.bazel Show resolved Hide resolved
protobuf_deps.bzl Outdated Show resolved Hide resolved
.bazelversion Outdated Show resolved Hide resolved
comius
comius reviewed Nov 20, 2023
View reviewed changes
BUILD.bazel Show resolved Hide resolved
BUILD.bazel Outdated Show resolved Hide resolved
.bazelversion Outdated Show resolved Hide resolved
@thesayyn thesayyn mentioned this pull request Jan 8, 2024
Merged
comius pushed a commit to bazelbuild/rules_proto that referenced this pull request Jan 16, 2024
@thesayyn
fix: set allowlist_different_package conditionally (#199)
e3885ef 
See:
protocolbuffers/protobuf#14590 (comment)
@thesayyn thesayyn marked this pull request as ready for review February 2, 2024 19:27
@thesayyn thesayyn requested review from a team as code owners February 2, 2024 19:27
@thesayyn thesayyn requested review from acozzette and shaod2 and removed request for a team February 2, 2024 19:27
@thesayyn
Copy link
Contributor Author

thesayyn commented Feb 2, 2024

@comius this should be ready now.

@thesayyn thesayyn changed the title refactor: enable incompatible_enable_proto_toolchain_resolution refactor: toolchainize language runtimes Feb 2, 2024
@thesayyn thesayyn requested a review from comius February 2, 2024 19:31
acozzette
acozzette requested changes Feb 2, 2024
View reviewed changes
.bazelignore Outdated Show resolved Hide resolved
@thesayyn thesayyn requested a review from acozzette March 5, 2024 21:25
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Mar 6, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Mar 6, 2024
@thesayyn
Copy link
Contributor Author

thesayyn commented Mar 7, 2024

@acozzette can you kick the CI again?

@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Mar 7, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Mar 7, 2024
@acozzette acozzette added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 26, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Apr 26, 2024
@github-actions GitHub Actions
Copy link

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment.

This PR is labeled inactive because the last activity was over 90 days ago. This PR will be closed and archived after 14 additional days without activity.

@github-actions github-actions bot added the inactive Denotes the issue/PR has not seen activity in the last 90 days. label Jul 26, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it.

This PR was closed and archived because there has been no new activity in the 14 days since the inactive label was added.

@github-actions github-actions bot closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaod2 shaod2 Awaiting requested review from shaod2 shaod2 was automatically assigned from protocolbuffers/protobuf-java

@comius comius Awaiting requested review from comius

@acozzette acozzette Awaiting requested review from acozzette

Assignees
No one assigned
Labels
inactive Denotes the issue/PR has not seen activity in the last 90 days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesayyn @acozzette @comius