Conformance tests for JavaScript (Node.js). 15 tests are failing. #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
|
|
||
| /* | ||
| * Protocol Buffers - Google's data interchange format | ||
| * Copyright 2008 Google Inc. All rights reserved. |
|
@haberman high level comment: can you please provide more context on what this change is trying to accomplish? I'm going into this without any background and a summary would help. A top-level comment in the conformance test wouldn't be a bad idea. |
haberman
changed the title
acozzette
reviewed
Mar 15, 2017
conformance/conformance_nodejs.js
Outdated
| function readBuffer(bytes) { | ||
| var buf = new Buffer(bytes); | ||
| var totalRead = 0; | ||
| //console.warn("Want to read: " + bytes); |
There was a problem hiding this comment.
It might be good to delete these commented out console.warn statements.
|
Could you perhaps add some short instructions to conformance/README.md about how to run the new tests? Otherwise LGTM! |
|
Addressed your comments, PTAL. Thanks! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review to @joeltine.