GA fixes #1847
Merged
GA fixes #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings us more into line with other langauges, and makes it more obvious when we are requiring protobuf generated code.
Ruby: generated foo.proto -> foo_pb.rb instead of foo.rb.
[ci skip] Change-Id: Ia0e0bf3bb6bd24633dc8f294318bb20ac837f8b9
Add a script to build protoc zip packages.
Ruby: translate package names from snake_case -> PascalCase.
We need to pick up some of the last-minute Ruby fixes.
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
|
Seems cpp_distcheck is still failing. Can you update Makefile.am to remove the deleted ruby files? |
|
Done, PTAL. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of a master, to pick up a few fixes from after the branch was cut.
Review to @xfxyjwf.