Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vcpkg to C++ installation instructions for Windows #3825

Merged
merged 1 commit into from
Jan 30, 2018

Conversation

ras0219-msft
Copy link
Contributor

Fixes issue #1154 by noting that vcpkg contains protobuf. Potential improvements: also remark how to use vcpkg to get dependencies when building from source via CMake.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@liujisi
Copy link
Contributor

liujisi commented Nov 13, 2017

The change looks good. Could you sign the cla please?

@podsvirov
Copy link
Contributor

Need add info about protobuf[zlib] feature package too.

@googlebot
Copy link

CLAs look good, thanks!

Fixes issue protocolbuffers#1154 by noting that `vcpkg` contains protobuf. Potential improvements: also remark how to use `vcpkg` to get dependencies when building from source via CMake.
@ras0219-msft
Copy link
Contributor Author

I signed it!

@liujisi
Copy link
Contributor

liujisi commented Jan 30, 2018

Thanks!

@liujisi liujisi merged commit 25a90e8 into protocolbuffers:master Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants