Add conformance test for php c back #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
php c extension has different result for conformance test for different php version and architecture. Try to add conformance back for php 7.1 c extension first.
TeBoring
force-pushed
the
php-conformance
branch
from
680a997
to
00e676d
Compare
32-bit and 64-bit have different failing tests
xfxyjwf
approved these changes
Jul 26, 2018
xfxyjwf
reviewed
Jul 26, 2018
tests.sh
Outdated
| pushd conformance | ||
| make test_php_c | ||
| popd | ||
| if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php c extension has different result for conformance test for different
php version and architecture. Try to add conformance back for php 7.1 c extension first.