Add source dependency of test suite implementation to main function #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do just enough in this PR to make the tests work again and do any follow-up refactoring in a separate PR? Ideally this PR should only contain changes to Makefile.am. |
|
Done in #5073 |
|
Bo, can you update the description of this PR accordingly? |
TeBoring
changed the title
|
Done |
This change adds a source dependency of the test suite implementaion class in the main function. For generality reason, the main function is moved to the file of the test suite implemetation. New test suite implementation will need to implement the main function. In order to make it easy for test suite implementation to implement the main function, this change also refactor out the common code out of the main function.
TeBoring
force-pushed
the
protobuf-conformance
branch
from
ad55f00
to
67a079d
Compare
haberman
approved these changes
Sep 6, 2018
conformance/conformance_test.h
Outdated
| // suite->RunSuite(&runner, &output); | ||
| // } | ||
| // MyConformanceTestSuite suite; | ||
| // MyConformanceTestRunner::Run(argc, argv, &sutie); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a source dependency of the test suite implementaion
class in the main function. For generality reason, the main function is
moved to the file of the test suite implemetation. New test suite
implementation will need to implement the main function.
In order to make it easy for test suite implementation to implement the
main function, this change also refactor out the common code out of the
main function.