Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JSON Loading of Any messages with Unknown Fields in C++ #5099

Merged
merged 3 commits into from
Sep 3, 2018

Conversation

brandoncole
Copy link
Contributor

@brandoncole brandoncole commented Aug 30, 2018

This change resolves #5086. Thanks to @mercret as well for the help.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@brandoncole
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@brandoncole brandoncole changed the title Fixes JSON Loading of Any messages with Unknown Fields Fixes JSON Loading of Any messages with Unknown Fields in C++ Aug 30, 2018
@xfxyjwf xfxyjwf self-assigned this Sep 1, 2018
@xfxyjwf xfxyjwf merged commit 37b5617 into protocolbuffers:master Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "Cannot find field" when using "ignore_unknown_fields" with 'Any' messages serialized as JSON
4 participants