Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt upb change for timestamp and duration json to php #5106

Merged
merged 10 commits into from
Sep 23, 2018
Merged

Adopt upb change for timestamp and duration json to php #5106

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
427e128
Adopt upb change for timestamp and duration json to php
TeBoring Aug 30, 2018
f1256d5
Remove unused code
TeBoring Aug 30, 2018
73aecac
Re-sync upb
TeBoring Aug 31, 2018
6e12f49
Fix php implementation timestamp json parsing
TeBoring Aug 31, 2018
41d4dab
Fix strptime use local timezone on mac.
TeBoring Sep 12, 2018
00c8795
Remove succeeding tests
TeBoring Sep 12, 2018
77390df
Resync
TeBoring Sep 21, 2018
5c2287f
Add tests for values
TeBoring Sep 21, 2018
01c2500
Fix php tests
TeBoring Sep 21, 2018
eba6260
Fix encoder handlers change default value
TeBoring Sep 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-sync upb
  • Loading branch information
@TeBoring
TeBoring committed Sep 21, 2018
commit 73aecac671c2a45b3c3a81f078f381e362e79a43
2 changes: 1 addition & 1 deletion php/ext/google/protobuf/upb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17289,7 +17289,7 @@ static bool printer_enddurationmsg(void *closure, const void *handler_data,
return false;
}

_upb_snprintf(buffer, sizeof(buffer), "%ld", p->seconds);
_upb_snprintf(buffer, sizeof(buffer), "%ld", (long)p->seconds);
base_len = strlen(buffer);

if (p->nanos != 0) {
Expand Down