Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(php): fix php serializeToJsonString empty ListValue. #5460

Closed
wants to merge 1 commit into from
Closed

fix(php): fix php serializeToJsonString empty ListValue. #5460

wants to merge 1 commit into from

Conversation

lightjiao
Copy link

@lightjiao lightjiao commented Dec 12, 2018

PHP function serializeToJsonString when have an empty ListValue, it return an invalid json, just like this

bug

{
    "name": "jack",
    "friends":,  // here should have an empty `[]`
    "age": 22
}

after fix

{
    "name": "jack",
    "friends": [],
    "age": 22
}

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@lightjiao
Copy link
Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@TeBoring TeBoring self-assigned this Dec 12, 2018
@TeBoring TeBoring self-requested a review December 12, 2018 19:00
@lightjiao
Copy link
Author

Hi,
Is there any problem on this pr ?

@TeBoring
Copy link
Contributor

Could you check whether master branch has already fixed this problem?

@TeBoring
Copy link
Contributor

#5106 may have fixed this.

@TeBoring
Copy link
Contributor

If it's not fixed, could you add a test to encode_decode_test.php?

@lightjiao
Copy link
Author

ok,
thanks.

@lightjiao
Copy link
Author

I have test on master branch, the problem has already fixed, but there is no empty ListValue test case in encode_decode_test.php.

I would add a test case.

thank you.

@lightjiao lightjiao closed this Dec 17, 2018
@lightjiao lightjiao deleted the lightjiao/fix-php-serializeToJsonString branch December 17, 2018 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants