-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(php): fix php serializeToJsonString
empty ListValue.
#5460
fix(php): fix php serializeToJsonString
empty ListValue.
#5460
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
CLAs look good, thanks! |
Hi, |
Could you check whether master branch has already fixed this problem? |
#5106 may have fixed this. |
If it's not fixed, could you add a test to encode_decode_test.php? |
ok, |
I have test on master branch, the problem has already fixed, but there is no empty ListValue test case in I would add a test case. thank you. |
PHP function
serializeToJsonString
when have an empty ListValue, it return an invalid json, just like thisbug
after fix