Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default values should also be serialized for json map key/value #5643

Merged
merged 1 commit into from
Jan 28, 2019
Merged

Default values should also be serialized for json map key/value #5643

merged 1 commit into from
Jan 28, 2019

Conversation

TeBoring
Copy link
Contributor

Fix #4389

@TeBoring
Copy link
Contributor Author

@stanley-cheung PTAL

stanley-cheung
stanley-cheung approved these changes Jan 28, 2019
View reviewed changes
Copy link
Contributor

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TeBoring TeBoring merged commit a21caa2 into protocolbuffers:master Jan 28, 2019
TeBoring added a commit to TeBoring/protobuf that referenced this pull request Jan 28, 2019
@TeBoring
Default values should also be serialized for json map key/value (prot…
3cae8e4 
…ocolbuffers#5643)
TeBoring added a commit that referenced this pull request Jan 28, 2019
@TeBoring
Merge pull request #5646 from TeBoring/3.7.x-cherrypick
32339be 
Default values should also be serialized for json map key/value (#5643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TeBoring @stanley-cheung @googlebot