Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reentrancy bug #36

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix reentrancy bug #36

merged 1 commit into from
Sep 4, 2023

Conversation

0xLucca
Copy link
Collaborator

@0xLucca 0xLucca commented Sep 1, 2023

This PR addresses a bug in multisig contracts with a threshold of 1. The bug caused that immediate execution of proposed transactions within the same call resulted in the loss of modified state. The fix ensures state preservation before executing the call.

Copy link
Member

@GabrielCamba GabrielCamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:rocket

@GabrielCamba GabrielCamba merged commit 32c39b2 into develop Sep 4, 2023
1 check passed
@GabrielCamba GabrielCamba deleted the fix-reentrancy-bug branch September 4, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants