Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BE: Audit: consider RBAC might be disabled #4138

Merged
merged 1 commit into from
Aug 18, 2023
Merged

BE: Audit: consider RBAC might be disabled #4138

merged 1 commit into from
Aug 18, 2023

Conversation

Haarolean
Copy link
Contributor

@Haarolean Haarolean commented Aug 18, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
RBAC might be disabled thus audit won't be able to cast user details.
Make it possible to fetch details for both RBAC and non-RBAC users.
Fixes #4131

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean self-assigned this Aug 18, 2023
@Haarolean Haarolean requested a review from a team as a code owner August 18, 2023 08:29
@Haarolean Haarolean enabled auto-merge (squash) August 18, 2023 08:35
@Haarolean Haarolean merged commit 1df8625 into master Aug 18, 2023
26 of 27 checks passed
@Haarolean Haarolean deleted the issues/4131 branch August 18, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit is not working with LDAP authentication
2 participants