Upgraded Dependencies #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded all dependencies to the latest versions:
I also replaced
requestwithgot, sincerequesthas been deprecated. This is a devDependency, so it only affected tests.I also bumped the version number to the next major version: 1.0.0. I did a major upgrade because the upgrades to
sanitize-htmlandvalidatorwere major releases which created a couple of non-backwards compatible changes to this node module:toHtml()have changed. (See Update default allowedTags in README.md apostrophecms/sanitize-html#421)toFloat()returns less false positives. (See fix(toFloat): verify the string can be safely converted to a float validatorjs/validator.js#1227)After this pull request is merged, we would need to run
npm publish.