Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1. #610

Merged
merged 63 commits into from
Jun 10, 2024
Merged

Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1. #610

merged 63 commits into from
Jun 10, 2024

Conversation

SpicyLemon
Copy link

@SpicyLemon SpicyLemon commented Jun 6, 2024 •
edited
Loading

Description

This PR merges SDK v0.50.7 into our customized release-pio/v0.50.x branch.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

mergify bot and others added 30 commits March 14, 2024 02:59
@mergify @rootulp @sontrinh16
fix(crypto): error if incorrect ledger public key (backport cosmos#19691
b8659ae 
) (cosmos#19745)

Co-authored-by: Rootul P <rootulp@gmail.com>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
@dependabot @github-actions
build(deps): Bump github.com/cometbft/cometbft from 0.38.5 to 0.38.6 (c…
6977c22 
…osmos#19751)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @mmsqe @tac0turtle
fix: align signer extraction adapter for mempool remove (backport cos…
9a59234 
…mos#19759) (cosmos#19773)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify @gibson042 @tac0turtle
fix(x/upgrade): Stop treating inline JSON as a URL (backport cosmos#1…
0df2902 
…9706) (cosmos#19767)

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify @julienrbrt
fix(client/v2): fix comment parsing (backport cosmos#19377) (cosmos#1…
1ad7fad 
…9777)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@dependabot @github-actions
@cool-develope @tac0turtle @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.0.1 to 1.1.1 in store (…
ff30f6e 
…cosmos#19770)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Cool Developer <cool199966@outlook.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@tac0turtle
chore(store): add release date (cosmos#19797)
a6c7aa5
@dependabot @github-actions
build(deps): Bump github.com/cosmos/gogoproto from 1.4.11 to 1.4.12 (c…
87ad797 
…osmos#19811)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @akaladarshi
@tac0turtle @julienrbrt
feat(x/gov): emit proposer address in submit proposal event (backport c…
a0faab3 
…osmos#19842) (cosmos#19844)

Co-authored-by: Aryan Tikarya <akaladarshi@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @kienn6034 @julienrbrt
feat(x/gov): emit depositor in proposal_deposit event (backport cos…
9c53142 
…mos#19853) (cosmos#19859)

Co-authored-by: Kien <kien@notional.ventures>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@yihuang
reuse fromAddrString (minor cleanup) (cosmos#19881)
d78edac
@mergify
feat(client): replace event-query-tx-for with wait-tx (backport c…
8641cd2 
…osmos#19870) (cosmos#19887)
@mergify @julienrbrt
feat(server): add custom start handler (backport cosmos#19854) (cosmo…
7b35e36 
…s#19884)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@dependabot @github-actions
@tac0turtle @julienrbrt
build(deps): Bump cosmossdk.io/store from 1.0.2 to 1.1.0 (cosmos#19810)
405471b 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify
docs(x/mint): Fix inconsistency in mint docs (backport cosmos#19915) (c…
f63e5fd 
…osmos#19925)
@dependabot @github-actions @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.1.1 to 1.1.2 (cosmos#…
4b71767 
…19985)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @julienrbrt
fix(client/v2): add encoder for cosmos.base.v1beta1.DecCoin (backport
525b720 
cosmos#19976) (cosmos#20001)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @GAtom22
@tac0turtle @julienrbrt
fix(mempool): use no-op mempool as default (backport cosmos#19970) (c…
f76c659 
…osmos#20008)

Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @lucaslopezf @julienrbrt
feat: Conditionally emit metrics based on enablement (backport cosmos…
974a24c 
…#19903) (cosmos#20017)

Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @mmsqe
fix(x/bank): align query with multi denoms for send-enabled (backport c…
452632f 
…osmos#20028) (cosmos#20029)

Co-authored-by: mmsqe <mavis@crypto.com>
@mergify @facundomedica
fix: Implement gogoproto customtype to secp256r1 keys (backport cosmo…
521ebe5 
…s#20027) (cosmos#20031)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
@mergify @mmsqe
fix(client/v2): respect output format from client ctx (backport cosmo…
741b01c 
…s#20033) (cosmos#20046)

Co-authored-by: mmsqe <mavis@crypto.com>
@dependabot @github-actions @julienrbrt
build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 (cosmos#20042)
d6a0fa1 
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify
feat(x/bank): support depinject for send restrictions (backport cosmo…
dafcc78 
…s#20014) (cosmos#20024)
@mergify
fix(baseapp): don't share global gas meter in tx execution (backport c…
9941498 
…osmos#19616) (cosmos#20050)
@mergify @facundomedica
fix: secp256r1 json missing quotes (backport cosmos#20060) (cosmos#20069
49c3ae6 
)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
@dependabot
build(deps): Bump github.com/cosmos/cosmos-proto from 1.0.0-beta.4 to…
a2abf1a 
… 1.0.0-beta.5 (cosmos#20095)
@mergify @julienrbrt
feat(client/v2): implement version filtering using annotation (backport
2a32f42 
cosmos#20083) (cosmos#20099)

Co-authored-by: Julien Robert <julien@rbrt.fr>
@julienrbrt
chore: prepare v0.50.6 (cosmos#19998)
4bd0e02
@mergify @mmsqe
fix: use timestamp for sim log file name (backport cosmos#20108) (cos…
0a682f7 
…mos#20111)

Co-authored-by: mmsqe <mavis@crypto.com>
dependabot bot and others added 22 commits April 29, 2024 08:31
@dependabot @github-actions
build(deps): Bump github.com/cometbft/cometbft from 0.38.6 to 0.38.7 (c…
f74c0e9 
…osmos#20206)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mergify @yihuang
@julienrbrt @sontrinh16 @tac0turtle
fix(server): bootstrap-state command can't parse latest genesis forma…
a65c2f7 
…t (backport cosmos#20020) (cosmos#20045)

Co-authored-by: yihuang <huang@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify @tac0turtle
fix: remove txs from mempool when antehandler fails in recheck (backp…
8ffc807 
…ort cosmos#20144) (cosmos#20251)

Co-authored-by: Marko <marko@baricevic.me>
@julienrbrt
feat(baseapp): expose grpc query router via depinject. (cosmos#20264)
bd886bb
@mergify @johnletey @julienrbrt
feat(client/v2): override short description in generated command (bac…
a2d3b2a 
…kport cosmos#20266) (cosmos#20269)

Co-authored-by: John Letey <j@letey.de>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @beer-1
feat(runtime): Add missing NewTransientStoreService (backport cosmos#…
9f8e3a5 
…20261) (cosmos#20327)

Co-authored-by: beer-1 <147697694+beer-1@users.noreply.github.com>
@mergify @facundomedica @tac0turtle
fix: allow tx decoding to fail in GetBlockWithTxs (backport cosmos#20323
3904228 
) (cosmos#20329)

Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify
fix(client/v2): correctly check subcommand short descriptions (backport
5d5e2d0 
cosmos#20330) (cosmos#20340)
@dependabot
build(deps): Bump cosmossdk.io/api from 0.7.4 to 0.7.5 (cosmos#20338)
b696f7a
@mergify
style: Fix gov query proposals examples syntax (backport cosmos#20353) (
5b6045c 
cosmos#20357)
@mergify @mmsqe @julienrbrt
feat(client): add consensus address for debug cmd (backport cosmos#20328
08fdfec 
) (cosmos#20366)

Co-authored-by: mmsqe <mavis@crypto.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @islishude @julienrbrt
feat(client): overwrite client context instead of setting new one (ba…
83747c5 
…ckport cosmos#20356) (cosmos#20383)

Co-authored-by: Shude Li <islishude@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@mergify @damiannolan
@julienrbrt @tac0turtle
fix: correctly assign execModeSimulate to context for simulateTx …
b99ca2c 
…(backport cosmos#20342) (cosmos#20346)

Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify @tianyeyouyou @tac0turtle
docs: update diagram to be shown properly (backport cosmos#20454) (co…
2ca9873 
…smos#20460)

Co-authored-by: tianyeyouyou <150894831+tianyeyouyou@users.noreply.github.com>
Co-authored-by: marbar3778 <marbar3778@yahoo.com>
@mergify @cocoyeal
docs: fix note blocks display failure (backport cosmos#20457) (cosmos…
5545d45 
…#20459)

Co-authored-by: cocoyeal <150209682+cocoyeal@users.noreply.github.com>
@mergify @polymaer
docs: update link contents (backport cosmos#20437) (cosmos#20462)
443f153 
Co-authored-by: PolyMa <151764357+polymaer@users.noreply.github.com>
@tac0turtle @sergio-mena @sontrinh16
fix(x/consensus): harden consensus params proposal (cosmos#20381)
d180df8 
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: sontrinh16 <trinhleson2000@gmail.com>
@mergify @tac0turtle
docs: add docs on permissions (backport cosmos#20526) (cosmos#20527)
9cfb349 
Co-authored-by: Marko <marko@baricevic.me>
@julienrbrt
chore(x/upgrade): bump vulnerable go-getter library (cosmos#20530)
9313b0f
@julienrbrt
chore: prepare v0.50.7 (cosmos#20475)
62212df
@SpicyLemon
Merge tag 'v0.50.7' into prov/dwedul/bump-to-v0.50.7
13c4370 
Release v0.50.7

# -----BEGIN PGP SIGNATURE-----
#
# iHUEABYKAB0WIQQQT/CpGzc0x0Rg2OeuqMIeYI8dAgUCZl7eUAAKCRCuqMIeYI8d
# AtSlAQDNDwdITCbVickPmwEE/jJWDCY+we8wsv+mtMXE7WLchwD/cNu3kNleerWh
# mre/fa+vON+1BHNMQuYrwJBbggcJEg8=
# =o7IA
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue Jun  4 03:28:48 2024 MDT
# gpg:                using EDDSA key 104FF0A91B3734C74460D8E7AEA8C21E608F1D02
# gpg: Can't check signature: No public key

# Conflicts:
#	baseapp/baseapp.go
@SpicyLemon
Add changelog entry and mark v0.50.7-pio-1 in the changelog.
6e96935
@SpicyLemon SpicyLemon marked this pull request as ready for review June 7, 2024 01:30
@SpicyLemon SpicyLemon changed the title Bring in SDK changes up to v0.50.7 Bring in SDK changes up to v0.50.7 and Mark v0.50.7-pio-1. Jun 10, 2024
@SpicyLemon
Copy link
Author

I ran the following make targets locally and they all completed successfully:

  • make test
  • make test-sim-nondeterminism
  • make test-sim-import-export
  • make test-sim-after-import
  • make test-sim-multi-seed-short

@SpicyLemon SpicyLemon enabled auto-merge (squash) June 10, 2024 22:47
iramiller
iramiller reviewed Jun 10, 2024
View reviewed changes
client/v2/internal/testpb/msg.proto
};

rpc Clawback(MsgClawbackRequest) returns (MsgClawbackResponse) {
option (cosmos_proto.method_added_in) = "cosmos-sdk v0.51.0";
Copy link
Member

@iramiller iramiller Jun 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this added in 0.51 if we are still in 0.50.7? These "added in" comments are not a great idea...

iramiller
iramiller approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@iramiller iramiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SDK team adding the "since version" stuff isn't a great pattern but as we are getting this from upstream it is what it is. The changes to the bank restrictions should be closely reviewed given the comments about bypassing module sourced transfers ... largely this should be ok as we had a long list of "special" accounts that wouldn't be restricted from these (and the sanction/quarantine functions too).

@SpicyLemon SpicyLemon merged commit 8e14244 into release-pio/v0.50.x Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iramiller iramiller iramiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpicyLemon @iramiller @tac0turtle @yihuang @julienrbrt