Implement consensus-specs/3875 #14458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
force-pushed
the
clspec-3875
branch
2 times, most recently
from
2b5fed2
to
31e723c
Compare
potuz
commented
Sep 24, 2024
| @@ -41,6 +41,7 @@ var placeholderFields = []string{ | |||
| "MAX_BYTES_PER_TRANSACTION", // Used for ssz of EL transactions. Unused in Prysm. | |||
| "MAX_EXTRA_DATA_BYTES", // Compile time constant on ExecutionPayload.extra_data. | |||
| "MAX_TRANSACTIONS_PER_PAYLOAD", // Compile time constant on ExecutionPayload.transactions. | |||
| "MAX_REQUEST_PAYLOADS", // Compile time constant on BeaconBlockBody.ExecutionRequests | |||
There was a problem hiding this comment.
Added this as a placeholder we don't seem to be using it! WARNING
potuz
commented
Sep 25, 2024
| @@ -55,7 +55,6 @@ type BeaconState struct { | |||
| latestExecutionPayloadHeader *enginev1.ExecutionPayloadHeader | |||
| latestExecutionPayloadHeaderCapella *enginev1.ExecutionPayloadHeaderCapella | |||
| latestExecutionPayloadHeaderDeneb *enginev1.ExecutionPayloadHeaderDeneb | |||
| latestExecutionPayloadHeaderElectra *enginev1.ExecutionPayloadHeaderElectra | |||
There was a problem hiding this comment.
We could keep this but instead of being an alias will add an unnecessary structure to the type
testing/spectest/mainnet/electra/epoch_processing/slashings_reset_test.go
Outdated
Show resolved
Hide resolved
testing/spectest/minimal/electra/epoch_processing/slashings_reset_test.go
Outdated
Show resolved
Hide resolved
terencechain
previously approved these changes
Sep 25, 2024
prestonvanloon
approved these changes
Sep 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ethereum/consensus-specs#3875
Reminder for myself. Never again suggest changes in the CL spec.