Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove finalized validator index to pubkey cache #14497

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Oct 2, 2024

What type of PR is this?

Other

What does this PR do? Why is it needed?

remove the finalized validator index to pubkey cache as a fork aware cache is not needed anymore after ethereum/consensus-specs#3818

note **

Finalizes deposit request position in the queue before applying it to the state. The outcome is that no new validator is created before the corresponding deposit is finalized hence no fork aware (pubkey, index) cache is required.
blocked by #14430

Which issues(s) does this PR fix?

Fixes #14436

Other notes for review

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@james-prysm james-prysm added Blocked Blocked by research or external factors Cleanup Code health! Electra electra hardfork labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked by research or external factors Cleanup Code health! Electra electra hardfork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find an approach to consolidate the existing validator Map with the new finalized validator index cache
1 participant