Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lint): run phpcs with php 7.4 #148

Merged
merged 1 commit into from
Jun 14, 2021
Merged

fix(lint): run phpcs with php 7.4 #148

merged 1 commit into from
Jun 14, 2021

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jun 10, 2021

Fixes the PHPCS check by running it directly.

This means we're losing the useful check annotations, but PHPCS had been failing with the following error:

Fatal error: Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.0.2". You are running 7.4.12. in /github/workspace/vendor/composer/platform_check.php on line 24

See: https://github.com/psalm/psalm-plugin-laravel/runs/2790324947

@caugner caugner marked this pull request as ready for review June 10, 2021 07:21
@caugner
Copy link
Contributor Author

caugner commented Jun 10, 2021

Maybe a better solution would be to use the shivammathur/setup-php@v2 action with: php-version: '7.4' before installing the Composer dependencies:

- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '7.4'

@caugner caugner changed the title fix(lint): run phpcs with php 8.0 fix(lint): run phpcs with php 7.4 Jun 10, 2021
@caugner
Copy link
Contributor Author

caugner commented Jun 10, 2021

Maybe a better solution would be to use the shivammathur/setup-php@v2 action with: php-version: '7.4' before installing the Composer dependencies:

- name: Setup PHP
  uses: shivammathur/setup-php@v2
  with:
    php-version: '7.4'

Indeed that worked, the phpcs-action is running fine now!

cc @mr-feek

@mr-feek mr-feek added the chore label Jun 14, 2021
@mr-feek mr-feek merged commit d0a084f into psalm:master Jun 14, 2021
@mr-feek
Copy link
Collaborator

mr-feek commented Jun 14, 2021

thanks!

@caugner caugner deleted the patch-2 branch June 15, 2021 10:50
@caugner caugner restored the patch-2 branch July 2, 2021 10:27
@caugner caugner deleted the patch-2 branch July 2, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants