-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Laravel 9 #213
Changes from 25 commits
b8913dc
538e1cb
6096cf0
c7a4457
8bf5d3f
7ba59e0
33a46af
95c9c06
5fb7f5a
08e9b38
74347de
3465c35
0892cd0
3f0479a
9d685ce
df524d6
11cb4da
ce996c6
3ddc65b
0dc88d3
a0d98b6
813874b
1c9e193
48b4fd7
e50f7f0
48d1c56
fad8f22
906d80f
de5f936
5fba336
07f342d
6c3c9b5
76a53f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,40 +8,11 @@ jobs: | |
strategy: | ||
fail-fast: false | ||
matrix: | ||
php: [7.3, 7.4, 8.0, 8.1] | ||
illuminate_version: [6.*, 8.*] | ||
php: [8.0, 8.1] | ||
illuminate_version: [8.67.*, 9.7.*] | ||
stability: [prefer-lowest, prefer-stable] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Actually, I think that There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Indeed, both can be used in combination I think. |
||
exclude: | ||
- illuminate_version: 6.* | ||
php: 7.3 | ||
stability: prefer-stable | ||
|
||
- illuminate_version: 6.* | ||
php: 7.4 | ||
stability: prefer-stable | ||
|
||
- illuminate_version: 6.* | ||
php: 8.0 | ||
stability: prefer-stable | ||
|
||
# Exclude unsupported combination | ||
# https://laravel.com/docs/8.x/releases#support-policy | ||
- illuminate_version: 6.* | ||
php: 8.1 | ||
|
||
# "Added PHP 8.1 Support from v8.67.0" | ||
# https://github.com/laravel/framework/blob/8.x/CHANGELOG-8.x.md#v8670-2021-10-22 | ||
# see also `matrix.include` section | ||
- illuminate_version: 8.* | ||
php: 8.1 | ||
|
||
include: | ||
# "Added PHP 8.1 Support from v8.67.0" | ||
- illuminate_version: ^8.67.0 | ||
php: 8.1 | ||
stability: 'prefer-stable' | ||
|
||
name: ${{ matrix.php }} | Illuminate ${{ matrix.illuminate_version }} | ${{ matrix.stability }} | ||
name: P${{ matrix.php }} | I ${{ matrix.illuminate_version }} | ${{ matrix.stability }} | ||
|
||
steps: | ||
- name: Checkout code | ||
|
@@ -56,7 +27,7 @@ jobs: | |
|
||
- name: Install dependencies | ||
run: | | ||
composer require "illuminate/container:${{ matrix.illuminate_version }}" "illuminate/contracts:${{ matrix.illuminate_version }}" "illuminate/database:${{ matrix.illuminate_version }}" "illuminate/http:${{ matrix.illuminate_version }}" "illuminate/support:${{ matrix.illuminate_version }}" --no-interaction --no-progress --prefer-dist --${{ matrix.stability }} | ||
composer require "laravel/framework:${{ matrix.illuminate_version }}" "illuminate/container:${{ matrix.illuminate_version }}" "illuminate/contracts:${{ matrix.illuminate_version }}" "illuminate/database:${{ matrix.illuminate_version }}" "illuminate/http:${{ matrix.illuminate_version }}" "illuminate/support:${{ matrix.illuminate_version }}" --no-interaction --no-progress --prefer-dist --${{ matrix.stability }} | ||
|
||
- name: Run Tests | ||
run: composer test |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,28 +11,29 @@ | |
} | ||
], | ||
"require": { | ||
"php": "^7.3|^8.0", | ||
"php": "^8.0", | ||
"ext-simplexml": "*", | ||
"illuminate/config": "^6.0 || ^8.0", | ||
mr-feek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"illuminate/container": "^6.0 || ^8.0", | ||
"illuminate/contracts": "^6.0 || ^8.0", | ||
"illuminate/database": "^6.0 || ^8.0", | ||
"illuminate/events": "^6.0 || ^8.0", | ||
"illuminate/http": "^6.0 || ^8.0", | ||
"illuminate/routing": "^6.0 || ^8.0", | ||
"illuminate/support": "^6.0 || ^8.0", | ||
"illuminate/view": "^6.0 || ^8.0", | ||
"illuminate/config": "^8.0 || ^9.0", | ||
"illuminate/container": "^8.0 || ^9.0", | ||
"illuminate/contracts": "^8.0 || ^9.0", | ||
"illuminate/database": "^8.0 || ^9.0", | ||
"illuminate/events": "^8.0 || ^9.0", | ||
"illuminate/http": "^8.0 || ^9.0", | ||
"illuminate/routing": "^8.0 || ^9.0", | ||
"illuminate/support": "^8.0 || ^9.0", | ||
"illuminate/view": "^8.0 || ^9.0", | ||
"vimeo/psalm": "^4.8.1", | ||
"orchestra/testbench": "^3.8 || ^4.0 || ^5.0 || ^6.22 || ^7.0", | ||
"barryvdh/laravel-ide-helper": ">=2.8.0" | ||
"orchestra/testbench": "^6.22 || ^7.0", | ||
"barryvdh/laravel-ide-helper": "^2.10" | ||
}, | ||
"require-dev": { | ||
"codeception/codeception": "^4.1.6", | ||
"codeception/module-phpbrowser": "^1.0.0", | ||
"codeception/module-asserts": "^1.0.0", | ||
"weirdan/codeception-psalm-module": "^0.13.1", | ||
"squizlabs/php_codesniffer": "*", | ||
"slevomat/coding-standard": "^6.2" | ||
"codeception/codeception": "^5.0", | ||
"codeception/module-asserts": "*@dev", | ||
"codeception/module-cli": "^2.0", | ||
"codeception/module-filesystem": "^3.0", | ||
"codeception/module-phpbrowser": "*@dev", | ||
"slevomat/coding-standard": "^6.2", | ||
"squizlabs/php_codesniffer": "*" | ||
}, | ||
"autoload": { | ||
"psr-4": { | ||
|
@@ -46,6 +47,7 @@ | |
}, | ||
"scripts": { | ||
"analyze": "psalm", | ||
"analyse": "psalm", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this looks accidental |
||
"lint": "phpcs -n", | ||
"lint-fix": "phpcbf -n", | ||
"test": "codecept run --skip-group skip", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we could support all versions in the same major release (1.x) -- Could you help me understand what might be a breaking change not allowing us to support these still? (I want to continue supporting laravel 6 til EOL, which is in september).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Laravel 6 won't work well on php 8. It's certainly not supported. That's why I believe laravel 6 support was dropped.
Is there a major issue with just issuing a 2.0 release for this PR? I don't understand the hesitation at doing a split release as has been already mentioned in this PR previously. See: #213 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Larastan (Laravel plugin for PHPStan) also released a new major version for Laravel 9.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My hesitation is just more maintenance overhead -- I would think we could solve that by adjusting the test matrix to not run laravel 6 on php 8 (like we are already doing with other tests) .
It's not a blocker, would just like to understand what exactly is causing the need for multiple versions