Drop Laravel 8 support #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue on vimeo/psalm repo is already fixed, but these changes are not tagged yet
This fixes issues like: here were 75 failures: 1) abort_if(): abort_if asserts not null Test tests/acceptance/AbortIf.feature:abort_if asserts not null Step Can see no errors Fail Failed to parse output: Uncaught RuntimeException: PHP Error: Creation of dynamic property PhpParser\Node\Stmt\Class_::$namespacedName is deprecated in /home/runner/work/psalm-plugin-laravel/psalm-plugin-laravel/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/SimpleNameResolver.php:229 in /home/runner/work/psalm-plugin-laravel/psalm-plugin-laravel/vendor/vimeo/psalm/src/Psalm/Internal/ErrorHandler.php:66
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according README.md, master branch should not support Laravel != 9