Eloquent Collection with templated keys #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refresh 3.x
# Conflicts: # stubs/BelongsToMany.stubphp # stubs/Collection.stubphp # stubs/EloquentBuilder.stubphp # stubs/EloquentCollection.stubphp # stubs/FactoryBuilder.stubphp # stubs/HasManyThrough.stubphp # stubs/Relation.stubphp
|
Hey @mr-feek This is the first PR for 3.x branch. I propose you to tag few alpha/beta/RC before the final release, but firstly let's support Laravel 10 on this branch, it will be my test task for the 3.x. One of ideas - use new Laravel's bin to generate Facade helpers - https://laravel-news.com/automatic-docblock-generation-on-facades. Stay tuned! :) |
alies-dev
changed the title
Remove Psalm 4 tests
# Conflicts: # stubs/BelongsToMany.stubphp # stubs/HasManyThrough.stubphp
alies-dev
changed the title
alies-dev
added
release:minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Larastan compatible syntax for Eloquent Collections:
instead of a single param syntax:
/** @return \Illuminate\Database\Eloquent\Collection<\App\Models\User> */use two params syntax:
/** @return \Illuminate\Database\Eloquent\Collection<int, \App\Models\User> */This will finally allow to use Psalm and Larastan at the same project without a lot of noise