Use orchestra/testbench-core as testbench should only be used for Package development

[crynobone]

In package development, orchestra/testbench should be added explicitly which then requires orchestra/workbench, orchestra/canvas etc which isn't useful for this package usage when used in Laravel project.

[alies-dev]

thank you, @crynobone ! I'll take a look into it soon, but firstly would like to understand why orchestra packages are not in dev requirements. It will take some time, but I'll do my best, thanks

[crynobone]

but firstly would like to understand why orchestra packages are not in dev requirements.

It is being used directly via the following class:

psalm-plugin-laravel/src/Providers/ApplicationProvider.php

Lines 11 to 23 in edc45c0

	use Orchestra\Testbench\Concerns\CreatesApplication;
	use function define;
	use function defined;
	use function dirname;
	use function file_exists;
	use function get_class;
	use function getcwd;
	use function microtime;
	final class ApplicationProvider
	{
	use CreatesApplication;

So changing to orchestra/testbench-core will be the most minimal changes to avoid loading requirements available via orchestra/testbench when using this package.

[alies-dev]

@crynobone

I have some questions regarding these changes in dependencies, can you please take a look?

[alies-dev]

^7.35 || ^8.15"

Do these versions contain for required functionality, or are they just to enforce new versions?

Note, this plugin built to support old versions

[crynobone]

Both versions contain conflict restrictions (using composer.json) to ensure Testbench Core 7 will only be used with Laravel 9 and Testbench Core 8 only used with Laravel 10.

[alies-dev]

I couldn't find places where we use Faker on this package. Do you know them?

[crynobone]

psalm-plugin-laravel/stubs/legacy-factories/FactoryBuilder.stubphp

Line 5 in edc45c0

use Faker\Generator as Faker;

[alies-dev]

this package is made to support both Laravel and Lumen. I'm not sure that require Laravel is a good idea.

[crynobone]

This is only require-dev deps. Previously was provided in require via orchestra/testbench.

So this actually improves support for Lumen.

[alies-dev]

Great, thank you, @crynobone
I see some issues caused updates on the trunk branch, but I'll fix them on my own.