Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the data vs json parameters more clear #5382

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

gdubicki
Copy link
Contributor

@gdubicki gdubicki commented Mar 9, 2020

As https://stackoverflow.com/q/26685248/2693875 question
and answer popularity shows that there is a lot of people who
do not understand the distinction.

As https://stackoverflow.com/q/26685248/2693875 question
and answer popularity shows that there is a lot of people who
do not understand the distinction.
@gdubicki
Copy link
Contributor Author

gdubicki commented Dec 3, 2020

Ping! Can I get a review, pretty please? :)

@hithwen
Copy link

hithwen commented Jun 30, 2021

Can we get this merged? I just lost half an hour on this

@Krogsager
Copy link

The current wording is counter intuitive, I recommend @gdubicki's PR.

Copy link

@abelcheung abelcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also agree that the wording in PR is clearer than original one.

@nateprewitt nateprewitt changed the base branch from master to main December 29, 2021 17:44
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @gdubicki!

@nateprewitt nateprewitt merged commit ab38e2c into psf:main Dec 29, 2021
@gdubicki gdubicki deleted the patch-1 branch December 29, 2021 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants