Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 mention on chardet behavior #6204

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

DavidCain
Copy link
Contributor

requests no longer supports Python 2. A recent commit, 8bce583
removed the chardet dependency for Python 2:

-'chardet>=3.0.2,<5; python_version < "3"',

We should edit the docs to remove mention of behavior on Py2.

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked for a small additional change, but otherwise looks good!

@@ -717,10 +717,9 @@ If ``chardet`` is installed, ``requests`` uses it, however for python3
library is an LGPL-licenced dependency and some users of requests
cannot depend on mandatory LGPL-licensed dependencies.

When you install ``request`` without specifying ``[use_chardet_on_py3]]`` extra,
When you install ``requests`` without specifying ``[use_chardet_on_py3]]`` extra,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related to your change but while we’re here can we remove the erroneous ] at the end of the extra?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely! Sorry I missed that.

`requests` no longer supports Python 2. A recent commit,
8bce583
removed the `chardet` dependency for Python 2:

```diff
-'chardet>=3.0.2,<5; python_version < "3"',
```

We should edit the docs to remove mention of behavior on Py2.
@DavidCain
Copy link
Contributor Author

Thank you both for the extremely speedy review! It does look like I'll need a maintainer to kick off CI though.

Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @DavidCain!

@nateprewitt nateprewitt merged commit 177dd90 into psf:main Jul 27, 2022
@DavidCain DavidCain deleted the dcain-chardet-py2 branch July 28, 2022 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants