Bump MSRV to 1.46 #659
Merged
Bump MSRV to 1.46 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We depend on bitflags through nix and apparently they raised their MSRV, so we have to follow. Fixes: #658 Signed-off-by: Uli Schlachter <psychon@znc.in>
Now that our MSRV was increased, clippy has lots of "new" things it
wants use to use.
Example warning:
error: match expression looks like `matches!` macro
--> generator/src/generator/mod.rs:84:5
|
84 | / match name {
85 | | "bigreq" | "ge" | "xc_misc" | "xproto" => false,
86 | | _ => true,
87 | | }
| |_____^ help: try this: `!matches!(name, "bigreq" | "ge" | "xc_misc" | "xproto")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
Signed-off-by: Uli Schlachter <psychon@znc.in>
This fixes the following clippy warning:
error: stripping a prefix manually
--> src/cursor/find_cursor.rs:266:36
|
266 | let mut path = &path[1..];
| ^^^^^^^^^^
|
= note: `-D clippy::manual-strip` implied by `-D warnings`
note: the prefix was tested here
--> src/cursor/find_cursor.rs:264:17
|
264 | if path.starts_with('~') {
| ^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
help: try using the `strip_prefix` method
|
264 ~ if let Some(<stripped>) = path.strip_prefix('~') {
265 | theme_dir.push(&home);
266 ~ let mut path = <stripped>;
|
Signed-off-by: Uli Schlachter <psychon@znc.in>
|
To Dos from #538 when/if this is merged (I am mentioning this here explicitly (a) to remind me (or someone else who wants to work on this), and (b) because clippy forced me to handle some points already):
|
I'll take care of that |
eduardosm
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on bitflags through nix and apparently they raised their MSRV,
so we have to follow.
Fixes: #658
Signed-off-by: Uli Schlachter psychon@znc.in