Get rid of unwrap() for array parsing in generated code #781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated code for parsing an array first got a slice of the expected length and then used the TryFrom trait to get an array. For example:
This commit introduces a helper function that produces an array directly. The above becomes:
The goal here is to remove some unwrap()s in the generated code, but this also helps shortening the code.
There are two new helper function: parse_u8_array parses an array while parse_u8_array_ref returns a reference to an array. Both cases are needed in the generated code.
Signed-off-by: Uli Schlachter psychon@znc.in