Add alignment wrapper to pthread_getattr_np. #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes stack corruption when using pthread_getattr_np on hirsute (Ubuntu 21.04) and libc >=2.33 This should also fix ptitSeb#130.
This was referenced Oct 17, 2021
|
Looks good to me. The attr wrapping was indeed missing there. |
|
Alright, also good from my end, but 130 might need reopening. |
|
The issue with Hirsute (I assume that why you mention #130 ) can probably be a new ticket, I suspect the source is different. |
|
They're still having a bit of trouble with Unity Preload. It's fine probably |
|
I need help I don't understand what any of the stuff you put above mean. can you please explain it to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes stack corruption when using
pthread_getattr_npon hirsute (Ubuntu 21.04) and libc >=2.33 by adding a wrapper withgetAlignedAttrWithInit(attr, 0).This should also fix #130, but I'm still waiting for verification.