bugfix: fix hsf isReference bug (apache#6033)

ptyin · Nov 16, 2023 · 3e9a46e · 3e9a46e
1 parent abfafc3
commit 3e9a46e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/changes/en-us/2.0.0.md b/changes/en-us/2.0.0.md
@@ -90,6 +90,7 @@ The version is updated as follows:
 - [[#6015](https://github.com/seata/seata/pull/6015)] fix can't integrate dubbo with spring
 
 ### optimize：
+- [[#6033](https://github.com/seata/seata/pull/6033)] optimize the isReference judgment logic in HSFRemotingParser, remove unnecessary judgment about FactoryBean
 - [[#5966](https://github.com/seata/seata/pull/5966)] decouple saga expression handling and remove evaluator package
 - [[#5928](https://github.com/seata/seata/pull/5928)] add Saga statelang semantic validation
 - [[#5208](https://github.com/seata/seata/pull/5208)] optimize throwable getCause once more

diff --git a/changes/zh-cn/2.0.0.md b/changes/zh-cn/2.0.0.md
@@ -90,6 +90,7 @@ Seata 是一款开源的分布式事务解决方案，提供高性能和简单
 
 
 ### optimize：
+- [[#6033](https://github.com/seata/seata/pull/6033)] 优化HSFRemotingParser中isReference判断逻辑，去掉关于FactoryBean的无用判断
 - [[#5966](https://github.com/seata/seata/pull/5966)] Saga 表达式解耦并统一格式
 - [[#5928](https://github.com/seata/seata/pull/5928)] 增加Saga模式状态机语义验证阶段
 - [[#5208](https://github.com/seata/seata/pull/5208)] 优化多次重复获取Throwable#getCause问题

diff --git a/...n-tx-api/src/main/java/io/seata/integration/tx/api/remoting/parser/HSFRemotingParser.java b/...n-tx-api/src/main/java/io/seata/integration/tx/api/remoting/parser/HSFRemotingParser.java
@@ -55,7 +55,7 @@ public boolean isRemoting(Object bean, String beanName) {
     @Override
     public boolean isReference(Object bean, String beanName) {
         String beanClassName = bean.getClass().getName();
-        return isHsf && ("com.taobao.hsf.app.spring.util.HSFSpringConsumerBean".equals(beanClassName) || "org.springframework.beans.factory.FactoryBean".equals(beanClassName));
+        return isHsf && "com.taobao.hsf.app.spring.util.HSFSpringConsumerBean".equals(beanClassName);
     }
 
     @Override