Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rails 5 deprecation warnings #247

Merged
merged 1 commit into from
Feb 18, 2016
Merged

Conversation

marcusg
Copy link
Contributor

@marcusg marcusg commented Jan 5, 2016

  • use :before_action instead of :before_filter
  • add "require: false" option to belongs_to associations

@marcusg
Copy link
Contributor Author

marcusg commented Feb 18, 2016

any chance that this gets merged some day?

@pokonski
Copy link
Member

@marcusg sure thing! I must have missed this one

pokonski added a commit that referenced this pull request Feb 18, 2016
fix rails 5 deprecation warnings
@pokonski pokonski merged commit e51b657 into public-activity:master Feb 18, 2016
@pokonski
Copy link
Member

Merged and released as 1.4.3 👍

@marcusg
Copy link
Contributor Author

marcusg commented Feb 18, 2016

@pokonski thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants