Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PublicActivity::StoreController #254

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Refactor PublicActivity::StoreController #254

merged 1 commit into from
Mar 18, 2016

Conversation

rmm5t
Copy link
Contributor

@rmm5t rmm5t commented Mar 17, 2016

  • Use Thread.current variables instead of class variables, ObjectSpace,
    and finalizers

Ref #252

@rmm5t
Refactor PublicActivity::StoreController
e61f58f 
* Use Thread.current variables instead of class variables, ObjectSpace,
  and finalizers

Ref public-activity#252
@rmm5t rmm5t mentioned this pull request Mar 17, 2016
Closed
@rmm5t
Copy link
Contributor Author

rmm5t commented Mar 17, 2016

See #255 to fix the build matrix errors.

@pokonski
Copy link
Member

Wow, I did not expect a PR 👍 StoreController was the nasty cave no one wanted to investigate before, so I appreciated this change even more :)

pokonski added a commit that referenced this pull request Mar 18, 2016
@pokonski
Merge pull request #254 from rmm5t/refactor-store-controller
26e19ff 
Refactor PublicActivity::StoreController
@pokonski pokonski merged commit 26e19ff into public-activity:master Mar 18, 2016
@rmm5t rmm5t deleted the refactor-store-controller branch March 18, 2016 16:14
@rmm5t
Copy link
Contributor Author

rmm5t commented Mar 18, 2016

Sure thing. The way StoreController used to rely on garbage collection was a bit scary. Thanks for the rapid merge.

@pokonski
Copy link
Member

No problems, I'll back port that to stable branch and release a 1.5.0 :)

On 18 Mar 2016 17:16, "Ryan McGeary" notifications@github.com wrote:

Sure thing. The way StoreController used to rely on garbage collection
was a bit scary. Thanks for the rapid merge.

—
You are receiving this because you modified the open/close state.

Reply to this email directly or view it on GitHub

@rmm5t
Copy link
Contributor Author

rmm5t commented Mar 18, 2016

I'll back port that to stable branch and release a 1.5.0 :)

Excellent. You read my mind. I was just considering asking about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmm5t @pokonski