Added Cosmos proto types and MsgDelegate proto #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanev
changed the title
|
Yeah I don't think embedding is actually possible golang/protobuf#192 (comment) The only work around I see is duplicating fields, its a bit boilerplate but that would make it work, I'm ok duplicating that unless you think there is some methods attached to MsgDelegate that would requite to also be copied to MsgPost ? |
jhernandezb
approved these changes
May 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
I couldn't figure out how to write a protobuf for
MsgPostsince it includesMsgDelegateas an embedded type. Anyone know if this is possible? I'm leaving it as a Go type for now.