Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post events #50

Merged
merged 3 commits into from
Jun 22, 2020
Merged

post events #50

merged 3 commits into from
Jun 22, 2020

Conversation

jhernandezb
Copy link
Member

@jhernandezb jhernandezb commented Jun 22, 2020 •
edited
Loading

  • enforces post creation in a different transaction
  • renames module name
  • adds missing event property

@jhernandezb jhernandezb requested a review from shanev June 22, 2020 14:39
shanev
shanev approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@shanev shanev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did the name change on my branch as well but let’s get this in.

@shanev shanev merged commit 9b1e2ba into master Jun 22, 2020
@jhernandezb jhernandezb deleted the jhernadnez/edit-events branch July 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanev shanev shanev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhernandezb @shanev