-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module FA #908
base: main
Are you sure you want to change the base?
Add module FA #908
Conversation
This is great thank you ! we will take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just two main things
- The Feeabskeeper is not actually passed in to the ante handler options, so any tx would fail when mpog is non zero. Adding
FeeAbskeeper: app.FeeabsKeeper,
here should fix itLines 861 to 867 in 505f915
HandlerOptions: ante.HandlerOptions{ AccountKeeper: app.AccountKeeper, BankKeeper: app.BankKeeper, SignModeHandler: encodingConfig.TxConfig.SignModeHandler(), FeegrantKeeper: app.FeeGrantKeeper, SigGasConsumer: ante.DefaultSigVerificationGasConsumer, }, - Adding the feeabs storekey to the upgrade handler
Minor:
Noticed you modified the go.mod go version to older one. Any specific reason why?
Hi @spoo-bar. Thanks for your reviewed. I've updated to the PR |
This PR will
This PR is ready for review but probably right now it shouldn't be merged because we are completing the audit.