Add test workflow #1750
Merged
Add test workflow #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @WalshyDev! We used to run the tests when the CI was run in Travis, it seems we have forgot to port it here. Thanks for your PR, very appreciated. It actually comes with a very appropriate timing, as we're currently discussing to expand the list of checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new workflow to help with the reviewing of PSL submissions.
Right now this workflow will only run
make testso reviewers can be assured that tests do pass without issue.In the future, this can be expanded to check the order, check DNS entries, etc.
Wanted to make sure we started simple right now.
Some submitters have had issues running the tests (such as #1562) or don't post the result / just say "passed". This will mean the tests just run in GitHub and can always be seen as passing/failing.
Example run of this push from my own fork: https://github.com/WalshyDev/list/actions/runs/4850740715/jobs/8643920527