target: Update LRU config mechanism #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulsc96
approved these changes
Oct 4, 2023
JosseVanDelm
added a commit
to JosseVanDelm/snitch_cluster
that referenced
this pull request
Dec 11, 2023
* sw: add test and golden model for subtraction * lint: formatting datagen.py * Apply suggestions from code review Co-authored-by: Josse Van Delm <josse.vandelm@gmail.com> * sw: format snax-gemm-lib.c --------- Co-authored-by: Josse Van Delm <josse.vandelm@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the LRU config file mechanism in the following way.
The LRU config file becomes a symlink, pointing to the
cfg/default.hjsonconfig file by default. Upon an override request (using theCFG_OVERRIDEflag) the symlink is updated to point to the requested config file. This is in contrast to the previous implementation, where the LRU config file was a regular file, and the contents of the default or overridden config files were copied into it.This change allows the following behaviour. If the config file which the LRU config points to changes, any Make target depending on the LRU config will be updated. So you don't have to update the LRU config file contents, but can directly update the original config file (which is now the target of the symlink).