Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cert-manager format #313

Closed
fao89 opened this issue Dec 16, 2021 · 0 comments · Fixed by #314
Closed

Support cert-manager format #313

fao89 opened this issue Dec 16, 2021 · 0 comments · Fixed by #314

Comments

@fao89
Copy link
Member

fao89 commented Dec 16, 2021

When using cert-manager to generate TLS certs for pulp-operator, we need to 'copy' the data from the secret and reformat it for the container_token_secret.

What we should do, is replace our format with cert-manager format. We can preserve backwards compat but should recommend cert-manager as the default.

apiVersion: v1
kind: Secret
metadata:
name: example-tls
namespace: foo
data:
tls.crt: <base64 encoded cert>
tls.key: <base64 encoded key>
type: kubernetes.io/tls
fao89 added a commit to fao89/pulp-operator that referenced this issue Dec 16, 2021
fao89 added a commit to fao89/pulp-operator that referenced this issue Dec 16, 2021
fao89 added a commit to fao89/pulp-operator that referenced this issue Dec 16, 2021
fao89 added a commit to fao89/pulp-operator that referenced this issue Dec 16, 2021
fao89 added a commit that referenced this issue Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant