Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decaffeinate config spec #68

Merged
merged 3 commits into from
May 21, 2023
Merged

Decaffeinate config spec #68

merged 3 commits into from
May 21, 2023

Conversation

2colours
Copy link
Contributor

@2colours 2colours commented Apr 8, 2023

No description provided.

@2colours 2colours mentioned this pull request Apr 8, 2023
Closed
12 tasks
@2colours
Copy link
Contributor Author

2colours commented Apr 8, 2023

This is meant to supersede #24.

As the relevant files haven't been modified, it's a mere rebase, plus semicolons readded.

@2colours 2colours marked this pull request as ready for review April 8, 2023 21:07
confused-Techie
confused-Techie requested changes May 19, 2023
View reviewed changes
Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good, diff looks good. There's a single simple change I've pointed out, but otherwise this one should be good to go

spec/config-spec.js Show resolved Hide resolved
@2colours @confused-Techie
comment got deleted accidentally
6dadfd7 
thanks @confused-Techie for pointing out

Co-authored-by: confused_techie <dev@lhbasics.com>
DeeDeeG
DeeDeeG approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DeeDeeG
Copy link
Member

DeeDeeG commented May 21, 2023

Comment was restored as requested, I'm merging this one. Thanks for this.

@DeeDeeG DeeDeeG merged commit a5bb866 into pulsar-edit:decaf May 21, 2023
@2colours 2colours deleted the decaffeinate-config-spec branch May 21, 2023 08:07
@DeeDeeG DeeDeeG mentioned this pull request Sep 8, 2023
Closed
@DeeDeeG DeeDeeG mentioned this pull request Sep 17, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@confused-Techie confused-Techie confused-Techie requested changes

@DeeDeeG DeeDeeG DeeDeeG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2colours @DeeDeeG @confused-Techie @GuilleW