Decaffeinate docs spec #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let > var semicolons > no semicolons unused parameters with leading underscore
DeeDeeG
approved these changes
May 21, 2023
There was a problem hiding this comment.
LGTM. Nice to get rid of all those not-helpful returns.
Again, I see no failures in CI.
As I commented in the other PR, I personally don't like losing all the blank lines between bits of code, but I'm waiting on a second opinion of another reviewer agreeing, so please leave it as-is for now, unless/until another reviewer says they agree with wanting to keep the blank lines.
confused-Techie
approved these changes
May 21, 2023
|
Some accidental stray spaces at the beginnings of lines were added. Gonna clean those up real quick. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to supersede #27.
Again, it's almost verbatim because there have been no modifications upstream.
Otherwise, nothing unusual - less
functions, and unused parameters might go with the underscore, linters tend to like that.