Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaffeinate featured spec #73

Merged

Conversation

2colours
Copy link
Contributor

Meant to supersede #29.
Since there have been no modifications to this file since, it's really only about the semicolons.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, no failing tests in CI.

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Passing tests, and a clean decaf work. Appreciate it! Just like @DeeDeeG mentioned some breathing room is always nice, (I may have missed the exclusion of this in earlier PRs) but it's not a blocker at all, so I've just done a quick commit for it, so I didn't have to take your time. I'll merge this one now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants