Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaf Source #84

Merged
merged 62 commits into from
Jul 23, 2023
Merged

Decaf Source #84

merged 62 commits into from
Jul 23, 2023

Conversation

confused-Techie
Copy link
Member

This PR decafs the entire source of PPM. Following with our current guidelines of initially comparing against a machine decaf branch. Once ready to merge, the target branch will be changed to master. This is done to make review possible, as there's something to compare changes against.

The vast majority of this decaf is rather light, this is done on purpose, since I'd rather not break anything, especially considering that the vast majority of modified values are passed around rather than originating in any particular function.

@confused-Techie
Copy link
Member Author

So knowing the tendency of decaf PRs to properly have a review, I may just go ahead and trust the tests on this one, since there are a few other changes I'd actually like to make beyond just decaf work.

So knowing that all tests are passing here except "Windows - NodeJS 16" and "Windows - NodeJS 18" (Which are the fault of windows being unable to build the native modules we use after our upgrade to node-gyp, which should be solved once we can switch over to second-mate from first-mate since we had to do the same to bump NodeJS versions over in the Pulsar repo).

But this means the failures there are excepted, and otherwise all tests are passing totally fine.

So I'll go ahead and change the target branch to master and let our tests run to ensure everythings fine, then merge. Thanks to @DeeDeeG for all the assistance in getting things sorted over here.

@confused-Techie confused-Techie changed the base branch from machine-decaf-source to master July 23, 2023 21:04
@confused-Techie confused-Techie merged commit 520ffcd into master Jul 23, 2023
9 of 11 checks passed
@confused-Techie confused-Techie deleted the manual-decaf-source branch July 23, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant