deps: Specify superstring as a tarball URL, not a git URL #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarballs are the simpler format for package managers to handle. Git URLs are cloned into a temp dir, installed there, then the result is copied. Tarballs are simply fetched and extracted. For performance and simplicity, tarballs should be preferred over git URLs where possible.
Draft
2 tasks
confused-Techie
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
While I can't verify about this being simpler, I'll trust you there and confirm the sha specified is identical, so in any case this should be an exact change to something that's easier on a technical level for installation, which is always great. Lets get it merged!
Also love the amount of care and attention you and I have given to this repo recently, it's nice to go a bit overboard with one repo until there's zero other changes that should really occur anytime soon. Gives some level of completeness lol
|
Thanks! (Merging now!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specified the
superstringdependency as as a tarball URL inpackage.json, not as a git URL.Motivation:
Tarballs are the simpler format for package managers to handle.
(Git URLs are cloned into a temp dir, installed there, then the result is copied. Tarballs are simply fetched and extracted.)
In my opinion, for reasons of performance and simplicity, tarballs should be preferred over git URLs in
package.json, where possible.(Note: I forgot to do it this way in #5, but I remembered while I was going over to update *this* package as a dependency in the
githubpackage repo. I figured I can circle back and do it now.)