-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move closure serialization logic into lumirt #14
Comments
Note - as part of this, it should also be much easier to add test cases that validate the serialization logic. |
lukehoban
added a commit
that referenced
this issue
Aug 19, 2017
Add support for serializing captured arrays into JavaScript closures. See pulumi/pulumi@575102c for the other half of this. Ideally we will move most of this logic into lumirt which will also reduce the total complexity of this encoding. We are tracking that in #14.
lukehoban
added a commit
to pulumi/pulumi
that referenced
this issue
Oct 7, 2017
This logic was previously in the `@pulumi/aws` pacakge. Moving it into the `pulumi` SDK as part of the overall closure serialization logic to make it more broadly accessible, and to centralize this functionality. Now that it's all in one place, we may decide to remove the publically exposed `Closure` abstraction completely, which may also enable significant simplicifcation to the logic in closure serialization. Also add one initial test case for this code. Fixes pulumi/pulumi-aws#14.
lukehoban
added a commit
to pulumi/pulumi
that referenced
this issue
Oct 7, 2017
This logic was previously in the `@pulumi/aws` pacakge. Moving it into the `pulumi` SDK as part of the overall closure serialization logic to make it more broadly accessible, and to centralize this functionality. Now that it's all in one place, we may decide to remove the publically exposed `Closure` abstraction completely, which may also enable significant simplicifcation to the logic in closure serialization. Also add one initial test case for this code. Fixes pulumi/pulumi-aws#14.
lukehoban
added a commit
that referenced
this issue
Oct 7, 2017
This is now available directly from the pulumi SDK via pulumi/pulumi#402. Fixes #14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The implementation of
aws.serverless.Function
includes both the API surface area as well as a lot of logic for serializing the closure environment. The vast majority of that logic is not AWS or Lambda specific, and should be pushed down into the lumirtserializeClosure
abstraction instead.The text was updated successfully, but these errors were encountered: