Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overlays for types where JSON strings are expected #38

Closed
lukehoban opened this issue Oct 2, 2017 · 3 comments
Closed

Add overlays for types where JSON strings are expected #38

lukehoban opened this issue Oct 2, 2017 · 3 comments
Assignees
@mmdriley
Milestone
0.8

Comments

@lukehoban
Copy link
Member

lukehoban commented Oct 2, 2017 •
edited
Loading

There are many places where Terraform providers accept a JSON string. We should at least add overlays that provide the shapes of those JSON objects. And likely we should consider transformation on the properties that allow passing strongly typed object values instead of JSON strings from Pulumi.

See for example: https://github.com/pulumi/pulumi-service/commit/80a9d402bb30a948f09104df27a8fda647735e8d and pulumi/pulumi-cloud@999bdb1#diff-411860beb3c2bdcbd01894df3b3bd69aR20
@joeduffy
Copy link
Member

joeduffy commented Oct 2, 2017

Definitely a big 👍 on this.

I've run into this a few times (IAM policy documents and ECS TaskDefinitions, to name ones that come to mind).

Another annoying bit is the inconsistency in casing, which I'm not sure we can/should fix.

@lukehoban lukehoban mentioned this issue Oct 4, 2017
Merged
9 tasks
@joeduffy joeduffy added this to the 0.8 milestone Oct 10, 2017
@joeduffy
Copy link
Member

@mmdriley effectively did this as part of his CloudFormation work last sprint. But the resulting overlay types got added to the stack, rather than polished up overlays. This work item tracks graduating these to official overlay types, for a much (much (much)) nicer experience.

joeduffy added a commit that referenced this issue Oct 19, 2017
@joeduffy
Move AWS IAM document schemas into the resource package
275ab6d 
As part of bringing up our own CloudFormation stack using Pulumi,
@mmdriley schematized the IAM policy documents using JSON.  This
change moves them down into the AWS overlays so anyone can use them.

This is part of #38.  It's not 100% complete,
however, because it would be better to actually have the resources
simply take these types directly, rather than requiring
JSON.strinfication of the objects.
@mmdriley
Copy link
Contributor

mmdriley commented Oct 30, 2017 •
edited
Loading

The IAM overlay type was moved into pulumi-aws with 275ab6d and pulumi-service was rewritten to use it in https://github.com/pulumi/pulumi-service/commit/242316104ec84fb4e215dda82620019a3e4011ed. I expect we'll add new types as needed, but I'm closing this issue since it's served its purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmdriley mmdriley

Labels
None yet
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
3 participants
@lukehoban @mmdriley @joeduffy