-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overlays for types where JSON strings are expected #38
Comments
Definitely a big 👍 on this. I've run into this a few times (IAM policy documents and ECS TaskDefinitions, to name ones that come to mind). Another annoying bit is the inconsistency in casing, which I'm not sure we can/should fix. |
@mmdriley effectively did this as part of his CloudFormation work last sprint. But the resulting overlay types got added to the stack, rather than polished up overlays. This work item tracks graduating these to official overlay types, for a much (much (much)) nicer experience. |
As part of bringing up our own CloudFormation stack using Pulumi, @mmdriley schematized the IAM policy documents using JSON. This change moves them down into the AWS overlays so anyone can use them. This is part of #38. It's not 100% complete, however, because it would be better to actually have the resources simply take these types directly, rather than requiring JSON.strinfication of the objects.
The IAM overlay type was moved into |
There are many places where Terraform providers accept a JSON string. We should at least add overlays that provide the shapes of those JSON objects. And likely we should consider transformation on the properties that allow passing strongly typed object values instead of JSON strings from Pulumi.
See for example: https://github.com/pulumi/pulumi-service/commit/80a9d402bb30a948f09104df27a8fda647735e8d and pulumi/pulumi-cloud@999bdb1#diff-411860beb3c2bdcbd01894df3b3bd69aR20
The text was updated successfully, but these errors were encountered: