Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy property of aws.ecr.LifecyclePolicy should be strongly typed #633

Closed
mikhailshilkov opened this issue Jun 26, 2019 · 0 comments · Fixed by #660
Closed

policy property of aws.ecr.LifecyclePolicy should be strongly typed #633

mikhailshilkov opened this issue Jun 26, 2019 · 0 comments · Fixed by #660

Comments

@mikhailshilkov
Copy link
Member

We try to type policy documents as string | PolicyDocument. It looks like we do not do this for aws.ecr.LifecyclePolicy#policy.

Note that this has a different structure than aws.iam.PolicyDocument and would require a new Policy type.

I am not sure how many of other similar types would need to be created throughout the AWS provider. I picked this one from this example.
stack72 added a commit that referenced this issue Jul 18, 2019
@stack72
Adding an ECR LifeCycleDocument type
a698bff 
Fixes: #633

This will allow us to strongly type the ECR Lifecycle Policy rather
than needing to use JSON.stringify
@stack72 stack72 mentioned this issue Jul 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding an ECR Lifecycle Document Type pulumi/pulumi-aws
1 participant
@mikhailshilkov