Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an ECR Lifecycle Document Type #660

Merged
merged 2 commits into from
Jul 18, 2019
Merged

Adding an ECR Lifecycle Document Type #660

merged 2 commits into from
Jul 18, 2019

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jul 18, 2019

Fixes: #633

@stack72
Adding an ECR LifeCycleDocument type
a698bff 
Fixes: #633

This will allow us to strongly type the ECR Lifecycle Policy rather
than needing to use JSON.stringify
@stack72 stack72 force-pushed the stadck72/gh-633 branch 2 times, most recently from 103f425 to 57871ca Compare July 18, 2019 14:24
@stack72 stack72 self-assigned this Jul 18, 2019
@stack72 stack72 added area/providers impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features labels Jul 18, 2019
@stack72 stack72 merged commit 7b7f99b into master Jul 18, 2019
@stack72 stack72 deleted the stadck72/gh-633 branch July 18, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@jen20 jen20 jen20 approved these changes

Assignees

@stack72 stack72

Labels
area/providers impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

policy property of aws.ecr.LifecyclePolicy should be strongly typed
3 participants
@stack72 @jen20 @CyrusNajmabadi